PlayerIdentity returning values of other players / invalid data
Closed, ResolvedPublic
Actions

Description

PlayerIdentity seems to suffer from memory issues. When calling it there is a random chance that part of the struct data is from another player.
The issue is present in two completely unrelated mods.

The plain id is getting mixed up and the player name sometimes returns random memory.

SCRIPT       : string msg =  '[Admin Log] - Grim(76561198022879703) teleported to: Joni(76561198071370946)'
SCRIPT       : string msg =  '[Admin Log] - Grim(76561198071370946) teleported to: 4519.127441 339.000000 9628.681641'

The sender identity already returns invalid values on the script invoker:

[20:23:25][Admin Log] - hóÖk(76561198071370946) teleported to: 5664.659668 178.526581 12906.628906

Details

Severity: Block
Resolution: Open
Reproducibility: Sometimes
Operating System: Windows 10 x64
Category: General

Steps To Reproduce

Plain ID issue:

void RPCTeleportPlayer(PlayerIdentity sender, Object target,ParamsReadContext ctx)
{
    Param2<SyncPlayer,vector> teleportPlayerPacket;
    ctx.Read(teleportPlayerPacket);
    
    Man teleportTarget = GetPlayerObjectFromID(teleportPlayerPacket.param1.m_UID);
    if(teleportTarget)
    {
        teleportTarget.SetPosition(teleportPlayerPacket.param2);
        Logger.Log(sender.GetName() + "(" + sender.GetPlainId() + ") teleported to: " + teleportPlayerPacket.param2.ToString(false),LogType.AdminLog);
    };            
};

void RPCTeleportToPlayer(PlayerIdentity sender, Object target,ParamsReadContext ctx)
{
    Param1<SyncPlayer> teleportToPlayerPacket;
    ctx.Read(teleportToPlayerPacket);
    Man teleportToTarget = GetPlayerObjectFromID(teleportToPlayerPacket.param1.m_UID);

    if(teleportToTarget)
    {
        Man player = Man.Cast(GetPlayerObjectFromIdentity(sender));
        player.SetPosition(teleportToTarget.GetPosition());
        
        Logger.Log(sender.GetName() + "(" + sender.GetPlainId() + ") teleported to: " + teleportToTarget.GetIdentity().GetName() + "(" + teleportToTarget.GetIdentity().GetPlainId() + ")",LogType.AdminLog);
    };    
};

Additional Information

Suspected causes - Grim: PlayerIdentity cleanup/destructor or some weird scope thing

Event Timeline

Arkensor created this task.Sep 15 2019, 11:48 AM

Thurston added a subscriber: Thurston.Sep 15 2019, 11:51 AM

GrosTon1 added a subscriber: GrosTon1.Sep 15 2019, 11:57 AM

pls fix :)

Grim added a subscriber: Grim.Sep 15 2019, 12:21 PM

pls fix :)

Salutesh added a subscriber: Salutesh.Sep 15 2019, 12:58 PM

Unknown Object (User) added a subscriber: Unknown Object (User).Sep 15 2019, 12:59 PM

EinfachRobin added a subscriber: EinfachRobin.Sep 15 2019, 1:20 PM

DafixCz added a subscriber: DafixCz.Sep 15 2019, 1:25 PM

NiiRoZz added a subscriber: NiiRoZz.Sep 15 2019, 1:27 PM

Line that causes the issue is

Logger.Log(sender.GetName() + "(" + sender.GetPlainId() + ") teleported to: " + teleportToTarget.GetIdentity().GetName() + "(" + teleportToTarget.GetIdentity().GetPlainId() + ")",LogType.AdminLog);

after that point PlayerIdentity is corrupted in one way or another

philippjoos added a subscriber: philippjoos.Sep 15 2019, 2:29 PM

bombjack added a subscriber: bombjack.Sep 15 2019, 2:49 PM

Remoz added a subscriber: Remoz.Sep 15 2019, 3:45 PM

PR9INICHEK added a subscriber: PR9INICHEK.Sep 15 2019, 4:57 PM

play420 added a subscriber: play420.Sep 16 2019, 12:21 AM

Geez changed the task status from New to Assigned.Sep 16 2019, 2:34 PM

nigel added a subscriber: nigel.Sep 16 2019, 2:48 PM

sileed added a subscriber: sileed.Sep 16 2019, 2:56 PM

Cooltrain added a subscriber: Cooltrain.Sep 16 2019, 4:10 PM

I had some hard hours trying to figure out the Issue causing this Problem. It's happening when you want to use the PlainId (maybe other values too) of the Player and not save the PlainId in a variable first ! I fixed I by always using string steamid = player.GetIdentity().GetPlainId(); and then compare those values ! I did not test if this is enough, but what should be enough is this code:

void OnRPC( PlayerIdentity sender, int rpc_type, ParamsReadContext  ctx) {
	GetGame().RPCSingleParam(NULL, rpc_type, new Param1<string>(sender.GetPlainId()), true, sender);
}

Fixed version would be:

void OnRPC( PlayerIdentity sender, int rpc_type, ParamsReadContext  ctx) {
	string steamid = sender.GetPlainId(); 
	GetGame().RPCSingleParam(NULL, rpc_type, new Param1<string>(steamid), true, sender);
}

what it should do is sending the Players Steam Id back to himself, but this will somehow mix up everything.
Thats the reason why

The issue is present in two completely unrelated mods.

It's enough to have this error in ANY mod and every mod will be affected

lagtek13012 added a subscriber: lagtek13012.Oct 12 2019, 6:56 AM

@Geez
I hate to ping you, brother, but is there any update on this issue. It's something that is still happening and it's really annoying.

@Geez
Any action on this? It's still a huge problem patches later.

Hello everyone.
The problem has been tackled internally and the fix will appear in one of the upcoming updates.
Regards,
Geez

tjensen added a subscriber: tjensen.Aug 12 2022, 2:22 PM

lava76 added a subscriber: lava76.Aug 14 2022, 7:21 PM

NATION added a subscriber: NATION.Aug 15 2022, 8:06 PM

PlayerIdentity returning values of other players / invalid dataClosed, ResolvedPublicActions

Description

Details

Event Timeline

PlayerIdentity returning values of other players / invalid data
Closed, ResolvedPublic
Actions