Page MenuHomeFeedback Tracker

Filesize limits & directory creation
Closed, ResolvedPublic

Description

Add a parameter to bypass production restrictions

  • Allow unlimited filesize writing
  • Allow the creation of directories in $saves and $profiles
  • Disable limit on how many folders can be created per directory

Details

Severity
Major
Resolution
Open
Reproducibility
Always
Operating System
Windows 10 x64
Category
General

Event Timeline

Arkensor created this task.Apr 23 2019, 1:05 PM
rVn claimed this task.Apr 23 2019, 2:13 PM
rVn changed the task status from New to Acknowledged.

We definitely don't want this in the form of a parameter as that creates barriers for clients downloading the mod, we are currently looking at options of extending the limit or improving the functionality in a way that would allow us to remove it

rVn triaged this task as High priority.Apr 23 2019, 2:14 PM
Arkensor added a comment.EditedApr 23 2019, 2:15 PM

That makes sense. But as long as there is some limitation for "normal" users due to any security aspect or whatever reason, please add an easy way of bypassing that restriction if you are a developer and know what you are doing.

Splitting up my train mod to write 5 files instead of one because of the file size limit was no fun ;)
And I only use that during development, for shipping the json data is not an issue as there is no limit of how big a file can be to read

rVn added a comment.May 6 2019, 11:36 AM

proposed solution to this won't make it in time so we will temporarily increase the limit to 50MB per file in 1.03

If the directory creation in $profile is lifted, the file count cap can be avoided. I'm personally finding a lot of issues with creating a config json file on a regular player's system (or even an inexperienced server owner's server), because of the limit to file count and the fact that logs cycle (not a bad thing on the cycling, it just means that unless archived regularly, the cap is hit faster).

A devmode parameter will not be sufficient to resolve the max file count issue, as the general user does not set launch parameters to join servers.

i understand that on user side there have to be limitations, and solutions against abuse have to be found.

but note, that on the server side, this should not be the case, for obvious reasons.
there is no need to have such limitations on the server.

AXEL7 added a comment.May 21 2019, 5:10 PM

I believe that such restrictions should not be on the server side and on the client side for the single player mode (offline). In any case, I do not even see the reason for such restrictions, it creates additional difficulties in working on the game and its code for everyone who tries to create their modifications in any way. But if you have a need for this kind of thing, I would advise you to simply add an optional parameter to the configuration of the server and the game client that allows you to either remove such a lock or specify its size. This would solve a lot of questions and problems for both the authors of the game, as well as for the authors of modifications.

When the logs cycle and add to the file count, it will not be good enough

rVn renamed this task from Devmode parameter to Filesize limits & directory creation.May 29 2019, 3:49 PM
rVn closed this task as Resolved.Jun 18 2019, 10:36 AM

Limits removed in 1.04

Just noticed Arkensor wrote "Disable limit on how many folders can be created per directory" instead of "Disable limit on how many files can be created per directory"

Just to confirm this still means we can have unlimited files created in a directory with 1.04 yeah?

rVn added a comment.Jun 18 2019, 2:14 PM

yeah, Arkensor's sabotage failed