Page MenuHomeFeedback Tracker

JsonSerializer broken in 1.10
Closed, ResolvedPublic

Description

The JsonSerializer is unable to parse invalid JSON. It should return false when calling ReadFromString, but instead, it crashes on invalid JSON like this:

{
    "Departments": [
        {
            "DepartmentName": "My Department",
            "Sections": [
                {
                    "SectionName": "Developers",
                    "SectionLines": [
                        "First dev entry" 
                    //! <-------- missing ]
                },
                {
                    "SectionName": "Special Thanks",
                    "SectionLines": [
                        "Some guy"
                    ]
                }
            ]
        }
    ]
}

This makes most of the modded servers crash to desktop when they load mods that have some invalid JSON data in them.

Details

Severity
Crash
Resolution
Open
Reproducibility
Always
Operating System
Windows 10 x64
Category
General

Event Timeline

Arkensor created this task.Nov 21 2020, 2:27 PM
Jest added a subscriber: Jest.Nov 21 2020, 4:40 PM
Geez changed the task status from New to Assigned.Nov 23 2020, 11:27 AM
komer added a subscriber: komer.Nov 23 2020, 9:10 PM
Geez closed this task as Resolved.Nov 27 2020, 2:18 PM
Geez claimed this task.
Geez added a subscriber: Geez.

Hello Arkensor.
The issue has been resolved internally and the fix will appear in one of the upcoming updates.
Regards,
Geez