Page MenuHomeFeedback Tracker

Uniform and vest containers do not get deleted after addUniform and addVest commands
Closed, ResolvedPublic


When you add new uniform or new vest by addUniform or addVest command your old uniform or vest gets deleted but their container doesn't. In all other cases (clearItemCargo command on container with uniform or vest, deleting unit that wears uniform or vest) containers delete fine, its just addUniform and addVest commands.

Repro mission attached. {F23710}


Legacy ID
Steps To Reproduce
  1. Run attached containers_repro.Stratis mission with 1 player
  2. Observe hint and notice that current uniform container and vest container are saved in olduniform and oldvest variables
  3. Change your uniform and vest by "Change uniform" and "Change vest" actions.
  4. Observe that olduniform and oldvest containers were not deleted
Additional Information

Unlike addBackpack command which drops old backpack on ground, addUniform and addVest simply delete old uniform and vest, I believe that is should stay the same but along with item deletion it should delete uniform and vest container.

Event Timeline

SaMatra edited Steps To Reproduce. (Show Details)Apr 14 2014, 10:32 AM
SaMatra edited Additional Information. (Show Details)
SaMatra set Category to Scripting.
SaMatra set Reproducibility to Always.
SaMatra set Severity to None.
SaMatra set Resolution to Fixed.
SaMatra set Legacy ID to 1337683829.May 7 2016, 6:24 PM
SaMatra edited a custom field.

should be fixed in DEV. 124012(will be distributed tomorrow). So please give me a feedback whether my patch will really help

gdscei added a subscriber: gdscei.May 7 2016, 6:24 PM

I tried the repro out in DEV 29-4 124017, container variables in hint still not deleted.

still not deleted or start returning <NULL-object>? Because variables oldUniform and oldVest are still present, but should lead to a NULL object

The oldUniform and oldVest variables do return NULL object, but the container variables are not, they are still filled with the same data as before changing uniform/vest.

sorry, but I'm trying to understand you. Can you describe a concrete problem? Maybe with before/after image as attachment?

SaMatra added a subscriber: SaMatra.May 7 2016, 6:24 PM

Checked DEV version, everything works properly now, both addUniform and addVest commands delete previous uniform and vest.

SaMatra, are the containers variables cleared for you? They are not for me.

japa: will try this evening to get some images. Basicly, in the repro, there are two variables per clothing item (uniform & vest), oldUniform & uniformContainer, and oldVest & vestContainer. The oldUniform&oldVest variables are NULL when changed, but the container variables stay with the same data for me.

gdscei, yes, both addVest and addUniform properly delete previous containers as well as create new containers, you either use wrong dev version or its some kind of misunderstanding, everything works perfect for me.

Thanks, I will check this out tonight then. japa, this issue can be set as resolved then I think, if it works fine for SaMatra, must be something wrong with my set-up.
If I notice any other issue with this I will make a new issue (as I have been having some issues myself with items in uniforms/vest syncing to server, but that is a different problem)

just my 50cents: changes were made on data and code side. So Maybe you have a correct binary file, but still using an old version of Addons.

That could be possible, I will check it out tonight. Thanks!

Yeah, it's working now :)

MadDogX added a subscriber: MadDogX.May 7 2016, 6:24 PM

Mass closing tickets marked as resolved more than 1 month ago.

If the issue is in fact not resolved, please create a new ticket referencing this one and ask for it to be re-opened.