JIP damage is inconsistent with the server, for both pre-placed objects and spawned through the game.
Pre-placed objects, If you change the damage through script, it doesn't sync it properly:
Dynamically spawned objects sync damage properly for both normal and scripted damage, but a bit imprecise for some reason.
Main issue for me in this ticket is HandleDamage broadcasting damage to current clients but not JIP, this results in JIP seeing completely different picture from other clients, like them having no building at all because its dead for JIP but alive for other clients. HandleDamage used in repro mission is used to only allow damage to glass hit points, but ends up creating nasty desync situations like these:
Players being inside building that doesn't exist for JIP:
Ruins inside alive building:
Engine broadcasts result of HandleDamage at some point, not the event handler itself. The issue is that engine seems to ignore result of HandleDamage when storing damage values for map objects that will be sent to JIP clients, but correctly broadcasts them for existing clients. Logic:
Attached repro mission has this shown.
Why leave it bugged for JIP? Too hard to fix? Do you suggest manually setHit'ing applied damage on server to make it JIP compatible? Will this work?
handledamage alters damage locally after all the networking is done but thats not all. static building damage isaccumulative dam = olddam + newdam, now say new damage is 0 because you handed it, see where Im going? setHit is actually implementable
A command to force broadcast static building state to all clients and future JIP perhaps?
broadcastEntityState ENTITY which only works on primary entities (static buildings). This way I could at least script-queue this update on server side and broadcast it next frame? Or just for JIP since its the main issue?
Revision: 151244
forceHitpointsDamageSync command
non-static building should now have the same values not nearly the same