Page MenuHomeFeedback Tracker

Script Log prefix
Need More Info, LowPublic

Description

Is the prefix "SCRIPT : " really necessary in the script log? It seems a bit redundant seeing as it's in a dedicated file already labelled "script".

Details

Severity
Trivial
Resolution
Open
Reproducibility
Always
Operating System
Windows 10 x64
Operating System Version
N/A
Category
General
Steps To Reproduce

enable logging on server side. check script log and you'll see that every line printed has "SCRIPT : " prefacing any printed output.

Event Timeline

rVn triaged this task as Low priority.Apr 10 2019, 2:45 PM
rVn changed the task status from New to Need More Info.

That is appended internally to distinguish code/script messages during live debug, is it an issue in some way?

AussieCleetus added a comment.EditedApr 10 2019, 3:11 PM

From an optimitation standpoint it's just bloat. Though it's a minimal amount per line, it would reduce the amount of data written to the hdd. As more mods start printing to the file it really adds up quite fast. The cycling combats some of the issues but the script log really can get huge fast

3Vaker added a subscriber: 3Vaker.EditedApr 10 2019, 8:11 PM

AussieCleetus, in my opinion, mod creators should keep amount of stuff logged into script log as low as possible.
Rn some mods from top of Steam Workshop are just bombing these log files with useless debug messages (I guess you know, which mods I'm talking about), and 14 symbols is nothing compared to bloating output generated by these mods.
Besides that, this prefix won't affect client or server performance unless your mod is logging tons of characters, which you shouldn't do anyways.
So, compared to other problems, this is nothing. Rewriting entire logging system just to remove this prefix (which might affect performance even worse, as it will lead to generating 2 strings instead of one) - well, doesn't seem like a good idea
[offtopic] rVn, pls take a look at T136977

I do agree that the script log should be reduced in useage and kept for debugging (hence my mods that are made for extended logging info being moved to dedicated systems as the ADM file gets quite busy too). And absolutely there are some mods that spam the file a lot (despite having requested options from modders to be able to turn them off).

Changing a prefix added to every message isn't rewriting much considering it'd be a constant that is just placed at the start of the string before writing.

It was just a minor tweak request, I understand and agree that it's seriously not a huge issue. Though the spamming of "UpdateCanWork - SetEnergy" is not a great example to lead by (3_game\tools\component\componentenergymanager.c:449)