Page MenuHomeFeedback Tracker

SmokeShellGreen crashes the game
Closed, ResolvedPublic

Description

Upon trying to add a "SmokeShellGreen" to some container immediately crashes the game.

I haven't checked, but most likely all colored smokes are affected (maybe only the green one). White smoke ("SmokeShell") works fine though.

Details

Legacy ID
4007461290
Severity
None
Resolution
Fixed
Reproducibility
Always
Category
Game Crash
Steps To Reproduce
  1. Create a new mission,
  2. put a player down,
  3. and write the following into the init.sqf, maybe first try with a "SmokeShell" - which works, then try the green one.

// SmokeShellGreen repro (init.sqf)

  • spawn { sleep 2; hint "3"; sleep 1; hint "2"; sleep 1; hint "1"; sleep 1; _item = "SmokeShellGreen"; CRASH!! Try: "SmokeShell" -> works, or "HandGrenade" -> works, ... // but the green smoke one?! :( _container = vestContainer player; _container addItemCargoGlobal [_item, 1]; hint format["%1 added to %2", _item, _container];

};

Additional Information

Branch: Development
Version: 1.47.131402

If desired, I can upload some minidumps too, but I guess that won't be needed. I think colored smokes recieved some water fix these days/with the latest updates on dev. branch since any smoke thrown into water has yielded just white smoke. So maybe have a look at that diff first. Otherwise I have no idea where this comes from all of a sudden.

Event Timeline

ruebe edited Steps To Reproduce. (Show Details)Jul 4 2015, 2:09 AM
ruebe edited Additional Information. (Show Details)
ruebe set Category to Game Crash.
ruebe set Reproducibility to Always.
ruebe set Severity to None.
ruebe set Resolution to Fixed.
ruebe set Legacy ID to 4007461290.May 8 2016, 12:19 PM
Bohemia added a subscriber: Dwarden.Jul 4 2015, 2:09 AM
ruebe added a subscriber: ruebe.May 8 2016, 12:19 PM
ruebe added a comment.Jul 4 2015, 2:12 AM

RPT spam:

1:44:56 Warning Message: No entry 'config.bin/CfgWeapons.SmokeShellGreen'.
1:44:56 Warning Message: No entry '.scope'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: Error: creating weapon SmokeShellGreen with scope=private
1:44:56 Warning Message: No entry '.displayName'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.nameSound'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.type'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.picture'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.Library'.
1:44:56 Warning Message: No entry '.libTextDesc'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.model'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.simulation'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.fireLightDuration'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.fireLightIntensity'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.fireLightDiffuse'.
1:44:56 Warning Message: Size: '/' not an array
1:44:56 Warning Message: Size: '/' not an array
1:44:56 Warning Message: No entry '.fireLightAmbient'.
1:44:56 Warning Message: Size: '/' not an array
1:44:56 Warning Message: Size: '/' not an array
1:44:56 Warning Message: No entry '.weaponLockDelay'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.weaponLockSystem'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.cmImmunity'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.weight'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.lockingTargetSound'.
1:44:56 Warning Message: Size: '/' not an array
1:44:56 Warning Message: No entry '.lockedTargetSound'.
1:44:56 Warning Message: Size: '/' not an array
1:44:56 Warning Message: No entry '.detectRange'.
1:44:56 Warning Message: '/' is not a value
1:44:56 Warning Message: No entry '.muzzles'.

1:44:56 Warning Message: Size: '/' not an array


Exception code: C0000005 ACCESS_VIOLATION at 018EFB1C

^^ so it looks like SmokeShellGreen - or rather its path - is misconfigured. I'm pretty sure "config.bin/CfgWeapons.SmokeShellGreen" should be looking in CfgMagazines instead.

ruebe added a comment.Jul 4 2015, 2:27 AM

Same issue has already been reported in: http://feedback.arma3.com/view.php?id=24671
and most likely also this one: http://feedback.arma3.com/view.php?id=24667

And orange too!

3:39:14 Warning Message: No entry 'bin\config.bin/CfgWeapons.SmokeShellOrange'.
3:39:14 Warning Message: No entry '.scope'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: Error: creating weapon SmokeShellOrange with scope=private
3:39:14 Warning Message: No entry '.displayName'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.nameSound'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.type'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.picture'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.Library'.
3:39:14 Warning Message: No entry '.libTextDesc'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.model'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.simulation'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.fireLightDuration'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.fireLightIntensity'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.fireLightDiffuse'.
3:39:14 Warning Message: Size: '/' not an array
3:39:14 Warning Message: Size: '/' not an array
3:39:14 Warning Message: No entry '.fireLightAmbient'.
3:39:14 Warning Message: Size: '/' not an array
3:39:14 Warning Message: Size: '/' not an array
3:39:14 Warning Message: No entry '.weaponLockDelay'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.weaponLockSystem'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.cmImmunity'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.weight'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.lockingTargetSound'.
3:39:14 Warning Message: Size: '/' not an array
3:39:14 Warning Message: No entry '.lockedTargetSound'.
3:39:14 Warning Message: Size: '/' not an array
3:39:14 Warning Message: No entry '.detectRange'.
3:39:14 Warning Message: '/' is not a value
3:39:14 Warning Message: No entry '.muzzles'.
3:39:14 Warning Message: Size: '/' not an array

Also, I've commented out all references to coloured smokeshells in my missions I can find but keep getting this: (It does let me load though now)

4:00:20 Warning Message: No entry 'bin\config.bin/CfgMagazines.'.
4:00:20 Warning Message: No entry '.picture'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.scope'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: Error: creating magazine with scope=private
4:00:20 Warning Message: No entry '.displayName'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.displayNameShort'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.nameSound'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.Library'.
4:00:20 Warning Message: No entry '.libTextDesc'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.type'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.count'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.maxLeadSpeed'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.initSpeed'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.reloadAction'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.modelSpecial'.
4:00:20 Warning Message: '/' is not a value
4:00:20 Warning Message: No entry '.ammo'.
4:00:20 Warning Message: '/' is not a value

KDN added a subscriber: KDN.May 8 2016, 12:19 PM
KDN added a comment.Jul 4 2015, 6:04 AM

Well, it looks that it is definitely a starting point for troubleshooting this type of crash. (ref 0024667 )

R34P3R added a subscriber: R34P3R.May 8 2016, 12:19 PM
R34P3R added a comment.Jul 4 2015, 9:03 AM

03-07-2015
EXE rev. 131402 (game)
EXE rev. 131402 (launcher)
Size: ~153 MB

Fixed: Wrong smoke color for smokes thrown into the water (http://feedback.arma3.com/view.php?id=15875)

  • BIS pls test your work before releasing it.

EDIT: Same problem with SmokeShellRed

What about addMagazineCargoGlobal since smoke shell is a magazine, or addItemToVest where item could be anything?

if(vest player == "") then {

player addItemToUniform "SmokeShellGreen";

} else {

player addItemToVest "SmokeShellGreen";

};

not working :-(

KDN added a comment.Jul 4 2015, 8:39 PM

Any ideas how to by pass this and get the games going?

"Any ideas how to by pass this and get the games going?"

vestcontainer player addmagazinecargoglobal ["smokeshellgreen", 2]

this works

KDN added a comment.Jul 5 2015, 11:54 PM

I cannot even start virtual arsenal under LEARN. That is how bad the crash is. I am not sure if the smoke grenades is only issue here but those error lines are the last lines before the crash. Every time.

Of course, reversing back to the standard version, the problem disappears but my mission set up is using the new remoteExec and param commands that I have learned to love :)

Should be fixed in the next dev branch update. Marking as resolved, thanks a lot for all your feedback!

I just noticed that the engine part of the fix did it to the current update, but we experienced some data packing issues this morning and the data fix is not in there. I am very sorry for this. The game shouldn't crash anymore, but smokes won't work with some script commands until next update.

KDN added a comment.Jul 7 2015, 12:33 PM

Confirming above. Issue resolved but the smoke grenade error.
Thanks

ruebe added a comment.Jul 8 2015, 10:29 PM

This is not properly fixed yet. :/

While adding smoke shells with the command addItemCargoGlobal(!) doesn't crash the game any longer, the smokes are not useable at all (you can't throw them, you can't cycle through them, ...) - yet, upon opening the inventory, they are clearly there. What you can do is drop them to the ground, and pick em back up; and now, all of a sudden, you can use that smoke.

My guess is, that picking up a smoke uses a different command (probably the magazines one...), hence it will properly register it.

Long story short: addItemCargoGlobal and(!) smokes are still broken.
Please revisit.

smokes are magazines and not items. use addmagazinecargoglobal or additemtoxxxx for inventory as those have been tweaked to accept magazines.

ruebe added a comment.Jul 8 2015, 11:27 PM

oookay.
:)

Yet, at this point I do wonder:

  • If addItemToXXX works with anything ("The item can also be a a weapon or a magazine." - got it), why can't this be done for the addItemCargoGlobal too?
  • Why is there even a need for magazine/item/weapon variants in the first place, if one simple command could simply handle this on its own?! Or is there a catch?
  • And finally: before this color smoke update, adding smokes with addItemCargoGlobal worked *just fine*. Now it does not. Was that really necessary?

The (new) A3 inventory is already complex enough, why make it messy/cumbersome to use on top of it? I just don't get it. :/

--

On a similar note: why is there a need for all these global variants? Can't the commands just be global to begin with? Are there indeed use-cases where you'd want to addItem (or what not) only locally? What's the point? (...just curious here; I don't know too much about mp-scripting)

Ok, I try to explain this. This ticket is about crash. Crash is fixed. This ticket is therefore resolved. There is no point bringing up a dozen of other unrelated to this particular crash issues. If you have other issues, make another ticket, yet I advise against it as if it is about what you posted here, then this will be a waste of time. There are way to many more important issues to deal with than adding support for magazines to addItemCargoGlobal while there is a dedicated command for magazines. I hope you see some sense in what I just wrote.

ruebe added a comment.Jul 9 2015, 4:46 AM

This ticket is about crash. Crash is fixed.

And yet, we still have a command that, while no longer crashing the game, spawns an item into the inventory in an *invalid* state. Either that command can not be used with magazines (or weapons for that matter); then it should (gracefully) fail, or it should just fucking work. The current state is simply not acceptable.

Granted, this might have been the case before these crashes have been introduced, and I just didn't notice that the smokes were not actually functional... Then again, this only further stresses my point: either it works or the damn game needs to let me know that I'm doing something wrong.

If you have other issues, make another ticket,
yet I advise against it [...]

Or, you know... we could just stop being this anal about how-to-ticket, given the scope of this one here is debatable anyways: the crash was just a symptom, while addItemCargoGlobal is still broken, as argued above.

There are way to many more important issues to deal with [...]

There are always more important issues.
So what? :|

[...] than adding support for magazines to addItemCargoGlobal

Again you're confusing the symptom with the underlying problem. This is about a poor API. And the costs of a poor API (for everyone; be it the maintainers or the users) are horrendous.
If one "addItem" command can only add actual items, but other "addItem" commands can also add magazines and weapons, then something - clearly - went wrong, and it needs to be fixed, instead of carrying on with a bloated, ugly and prone to error API full of weird commands. Have you ever heard of PHP? :(

Now I'm certainly not going to open a ticket for a cleaned up API; but I thought it would be valuable to give at least some (general) feedback in here while we're at it. (ye, I know; this is not a forum jada, jada...)