Page MenuHomeFeedback Tracker

Workbench - CLI Packing does not change exit code if it failed to pack or there are critical script errors
Awaiting internal Testing, NormalPublic

Description

Game Version number: Current stable / Experimental
Modded?: Yes
If modded, please list the mods: N/A

Issue Description:

While trying to use Workbench in Continous Integration in ACE we've found out that the tools do not return error exit codes (always 0) while packing addons with errors that prevent the game from compiling ((E): Can't compile "Game" script module!).

This makes them not really that useful in for example detecting errors in Pull Requests or preventing auto-upload of broken build to Workshop.

Would be nice to have some insights from BI how the CI/CD is handled internally.

Details

Severity
None
Resolution
Open
Reproducibility
Always
Operating System
Windows 10 x64
Category
General
Steps To Reproduce

A:
Below branch of a repo has intentionally made invalid class AFM_Test that breaks the game:
https://github.com/ArmaForces/Mods_AR/tree/wb-pack-error-example

  1. clone
  2. adjust paths in build.bat
  3. run build.bat
  4. see that it happily packs invalid code
  5. return code 0

B:
I don't have a repro of this one but we had packing completely fail in below GitHub action:
https://github.com/Dahlgren/ACE-Anvil/actions/runs/9227052272/job/25388171019#step:6:1

yet despite the failure still a return code 0.

Event Timeline

veteran29 created this task.Jun 7 2024, 4:59 PM
ookexoo added a subscriber: ookexoo.Jun 8 2024, 7:25 PM
Geez changed the task status from New to Awaiting internal Testing.Jun 10 2024, 11:43 AM