Page MenuHomeFeedback Tracker

1.18 breaks keybind descriptions from mods
Closed, ResolvedPublic

Description

In past versions was worked when mod had keybind, it was translated and shown in options, now are fields empty{F2746468}

<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<modded_inputs>
    <inputs>
        <actions>
            <input name="UADayzDogWhistle" loc="#STR_DD_whistle" />
			<input name="UADayzDogFollow" loc="#STR_DD_followme" />
			<input name="UADayzDogPatrol" loc="#STR_DD_patrol" />
			<input name="UADayzDogStayHere" loc="#STR_DD_stayhere" />
        </actions>
    </inputs>
    <preset>
        <input name="UADayzDogWhistle">
            <btn name="kAdd" />
        </input>
		<input name="UADayzDogFollow">
            <btn name="kDivide" />
        </input>
		<input name="UADayzDogPatrol">
            <btn name="kMultiply" />
        </input>
		<input name="UADayzDogStayHere">
            <btn name="kSubstract" />
        </input>
    </preset>
</modded_inputs>

lang file:

Details

Severity
Minor
Resolution
Open
Reproducibility
N/A
Operating System
Windows 7
Category
General
Steps To Reproduce

install some mod with keybinds

go to options

you see empty lines without description

Additional Information

all works fine before 1.18

Event Timeline

Hunterz created this task.Jun 17 2022, 4:04 PM
Geez changed the task status from New to Assigned.Jun 20 2022, 6:32 PM
Geez changed the task status from Assigned to Acknowledged.Jun 21 2022, 2:44 PM
Geez added a subscriber: Geez.

Thank you for the report.
The issue has been confirmed and scheduled for a fix.
Though ideally, input loc value in the xml should not be prepended by '#'. (If you look at vanilla constants.xml, they are not present.)
So as an immediate fix, before the patch which restores the parsing of the incorrect definition ('#' prefix is for localization within EnFusion Script/UI), it will work if you remove the prepended '#'.
Regards,
Geez

Another cosmetic thing - in the past there was one single line with mod name before group of his keybinds. Will be good restore that feature too.

Geez closed this task as Resolved.Jun 23 2022, 11:00 AM
Geez claimed this task.

Hello Hunterz.
The issue has been resolved internally and the fix will appear in one of the upcoming updates.
Regards,
Geez