Compatible attachments defined in mods using compatibleItems class are not shown in the Arsenal.
Description
Description
Details
Details
- Legacy ID
- 3105282474
- Severity
- None
- Resolution
- Fixed
- Reproducibility
- Always
- Category
- Virtual Arsenal
Steps To Reproduce
Install mods using the compatibleItems {} class structure to define compatible accessories for weapons and test them in Arsenal.
Additional Information
Bug in the bis_fnc_compatibleItems function:
The isclass _x condition in the inner loop seems to be the cause, working if removed:
original:
if (isclass _cfgCompatibleItems) then {
{
if (getnumber _x > 0) then {_compatibleItems pushback configname _x;};
} foreach configproperties [_cfgCompatibleItems,"isclass _x"];
};Fixed:
if (isclass _cfgCompatibleItems) then {
{
if (getnumber _x > 0) then {_compatibleItems pushback configname _x;};
} foreach configproperties [_cfgCompatibleItems,"isnumber _x"];
};Event Timeline
Comment Actions
Simple fix, on a plate, please apply this BIS so we don't have to download this amendment after every update.
Thanks Robalo.
Comment Actions
Fixed in dev branch two weeks ago, could you please verify?
New function BIS_fnc_compatibleItems was written for it.
Comment Actions
Not resolved. There's a bug in the BIS_fnc_compatibleItems, see the aditional information section.
You are looping config properties of a compatileItems class and filtering them with isclass. Since it's not classes you're looking for, that inner loop will find nothing.
Comment Actions
Yea, the current function in the Arsenal on devBranch doesn't seem to be picking up the parameters from class compatibleItems. I.e. compatability defined in the format:
class compatibleItems {
MY_Optic1 = 1;
MY_Optic2 = 1;
};The list remains empty for weapons that only have a slot with compatibility defined in this manner.
Comment Actions
Updated the additional information section: the "isclass _x" filter should be "isnumber _x" instead.
Another thing, if this gets fixed, there is potential for the function to return duplicates and clutter the arsenal.
Comment Actions
Condition fixed, should appear in the next dev branch update.
BTW: Had to hack your ASDG Joint Rails addon and remove function hotfix from there, so I could actually test my fix :)
Comment Actions
Thanks a bunch Moricky, looks like today's dev has the fix.
Thoughts on making sure it does not return any duplicates ? New ticket ? =D
Comment Actions
Just noticed this condition was removed: if (getnumber _x > 0)
This means even attachments marked as incompatible (something = 0) will be returned.