Page MenuHomeFeedback Tracker

Need to be able to make glasses specified within a config mandatory or optional
Reviewed, WishlistPublic

Description

If you specify glasses for a unit in a config file, at present it makes them mandatory and ignores whatever selection a user has chosen in their profile.
There needs to be some flexibility in how this works, in many cases the preference would be let a users profile selection take priority over what is specified in the config.

As suggested by the moderators a sensible solution would be have a flag you could set within a units class e.g glassesAreCrucial = false

If set as false then a users profile selection takes priority.
If set as true then any glasses specified within the units "linkeditems" take priority

Divers for example would need to be set as true

Details

Legacy ID
2930445085
Severity
None
Resolution
Open
Reproducibility
Always
Category
Config
Steps To Reproduce
  1. Create a new class unit within a config file and specify any glasses within the units "linkeditems" e.g "G_Shades_Black".
  1. compile into PBO and put into addons folder
  1. Load game and go to profile settings. Change glasses to anything other than what is specified within the config file.
  1. Go to editor and place the unit created in the config file
  1. Start game and view units face. Profile selection has been ignored
Additional Information

Specifying glasses within the units init in the editor is the only way to override the default selection for the class unit.

Faces work as they should. i.e whatever face you select in your profile overrides faces set for a unit in a config file.

Event Timeline

Pomigit edited Steps To Reproduce. (Show Details)Jul 27 2013, 7:28 AM
Pomigit edited Additional Information. (Show Details)
Pomigit set Category to Config.
Pomigit set Reproducibility to Always.
Pomigit set Severity to None.
Pomigit set Resolution to Open.
Pomigit set Legacy ID to 2930445085.May 7 2016, 3:42 PM
AD2001 added a subscriber: AD2001.May 7 2016, 3:42 PM

I think it should be the way it is now.
/downvoted

Pomigit added a subscriber: Pomigit.May 7 2016, 3:42 PM

AD2001 - I'm not convinced you understand the issue mate. You do realise im talking about a config file for a mod dont you?

It doesnt make any sense for a config file to take priority over profile settings. It completely contradicts the point of giving people to option to customise their characters appearance.

I should also note that this is how faces work. i.e whatever face you select in your profile overrides faces set for a unit in a config file. Ive updated the description to state this

OK, so, when someone makes a mod with units and gives them goggles the goggles override the ones selected in the profile, right?
/upvoted

Yes that's correct.

Good stuff, thanks for upvoting :)

I find that it's ok the way it is now, for example this change would make the divers have sunglasses instead of diving goggles by default which I think would be worse.

For a "soft" definition, you could solve this by removing the glasses from the config, then running an init script that would check if the unit already has glasses and if not, give them the ones you want.

Thats a good point Sniperwolf572, perhaps a better solution though would be for BI to create exceptions to the rule for certain class. Divers are probably one of the few units where you wouldnt want it to override the settings.

Regarding your idea. It wouldnt really work because BI have it set up so tactical glasses are used by default. Besides I think modders need the flexibility to use whatever glasses they want.

Probably there should be a config option on glasses which have specific functionality to override the predefined or config'd goggles.

We had a bit of a chat between the moderators and figured that it wouldn't make sense to make glasses fight for priority. If that were the case, it would force someone to duplicate the classes for the glasses if they didn't think they are crucial. Also, if the config glasses had the priority switch you mention, and some other profile glasses had the same priority switch, there'd be a conflict which might not be satisfactory.

A more sensible config option would be to do something in the unit's config like:

"glassesAreCrucial = true"

Which would by default be false and you could change it for individual units in config.

So for example, this way, if the divers had this, they would, when spawned prioritize config glasses, while Pomigits units and all other units would allow the profile glasses to take over.

Pomigit, if you like what we're suggesting, please alter the ticket so we can review it, but we don't think that the current state of the ticket describes the solution would be beneficial to implement.

I think we are all on the same page and your suggestion makes perfect sense. Ticket updated to reflect your suggestion. Cheers for your input