Page MenuHomeFeedback Tracker

Move call to MiscGameplayFunctions.RemoveSplint from DeactivateCondition to OnDeactivate
Assigned, UrgentPublic

Description

The function call to MiscGameplayFunctions.RemoveSplint in DeactivateCondition of BrokenLegsMdfr should be moved to OnDeactivate where it logically belongs.
It makes adding additional Splints terrible in the sense that static functions can not call super and therefore a whole complete level of checks needs to be built in DeactivateCondition of the modifier to prevent the function being called or the player will always end up with a vanilla splint in their inventory.

Since playermodifiers got some additional love in 1.14 this might as well be corrected at the same time.

Details

Severity
Feature
Resolution
Open
Reproducibility
N/A
Operating System
Windows 10 x64
Category
General

Event Timeline

affenb3rt created this task.Sep 4 2021, 4:54 PM
Geez changed the task status from New to Assigned.Sep 6 2021, 5:09 PM