Page MenuHomeFeedback Tracker

Salmonella diseases trigger condition wrong
Closed, ResolvedPublic

Description

I'm not sure on the implemented status of diseases and weather these disease are even fully implemented. That being said I still spotted this, so I might be in error here but, inside

scripts\4_World\classes\playermodifiers\modifiers\diseases\salmonella.c

the trigger conditions for the disease check the cholera value for its activation

	override protected bool ActivateCondition(PlayerBase player)
	{
		if(player.GetSingleAgentCount(eAgents.CHOLERA) > SALMONELLA_AGENT_THRESHOLD_ACTIVATE) 
		{
			return true;
		}
		else 
		{
			return false;
		}
	}

Where I would have thought it should be checking eAgents.SALMONELLA and not eAgents.CHOLERA. Otherwise having cholera will also trigger salmonella.

Details

Severity
Minor
Resolution
Open
Reproducibility
Always
Operating System
Windows 7 x64
Operating System Version
Service Pack 1
Category
Gameplay
Steps To Reproduce

Open the code base to > scripts\4_World\classes\playermodifiers\modifiers\diseases\salmonella.c

Change the two trigger lines if this is actaully an issue.

Event Timeline

Geez changed the task status from New to Assigned.Apr 29 2019, 3:32 PM
Geez changed the task status from Assigned to Acknowledged.Apr 29 2019, 5:05 PM
Geez added a subscriber: Geez.

Thank you for the report Cooltrain.
The issue has been confirmed and scheduled for a fix.
Regards,
Geez

Geez closed this task as Resolved.May 15 2019, 11:11 AM
Geez claimed this task.

Hello Cooltrain.
The issue has been fixed internally and will be fixed on Steam in the future.
Regards,
Geez