Page MenuHomeFeedback Tracker

Berry_Canina have wrong model
Closed, ResolvedPublic

Description

If u read config file you see what
class Berry_Canina : BerryBase {

		displayName = "Canina berries";
		descriptionShort = "Great source of vitamin C!";
		model = "\dz\gear\food\Poisonousberries.p3d";

};
Berry_Canina have model Poisonousberries, but haven't poisonChance as opposed to
Berry_Sambucus.
class Berry_Sambucus : BerryBase {

		displayName = "Sambucus berries";
		descriptionShort = "Cooked berries of Sambucus are edible.";
		
		class UserActions : UserActions {
			class Eat : Eat {
				onComplete = "_poisonChance = random 1; switch true do {case (_poisonChance < 0.05): {[0,_person,'FoodPoisoning_MediumImpact'] call event_modifier;}; case (_poisonChance < 0.85): {[0,_person,'FoodPoisoning_LightImpact'] call event_modifier;};};";
			};
			
			class ForceFeed : ForceFeed {
				onComplete = "_poisonChance = random 1; switch true do {case (_poisonChance < 0.05): {[0,_target,'FoodPoisoning_MediumImpact'] call event_modifier;}; case (_poisonChance < 0.85): {[0,_target,'FoodPoisoning_LightImpact'] call event_modifier;};};";
			};
		};

};

Details

Legacy ID
1931779788
Severity
None
Resolution
Fixed
Reproducibility
Always

Event Timeline

PR9INICHEK set Category to category:items.Feb 16 2014, 8:58 AM
PR9INICHEK set Reproducibility to Always.
PR9INICHEK set Severity to None.
PR9INICHEK set Resolution to Fixed.
PR9INICHEK set Legacy ID to 1931779788.May 8 2016, 5:12 PM
R834 added a subscriber: R834.May 8 2016, 5:12 PM
R834 added a comment.Feb 16 2014, 1:03 PM

Sambucus uses blueberries.p3d
Canina uses Poisonousberries.p3d
The Sambucus is actually the poisonous one

That's what is being reported.

This is either a genuine mix up of the models (problem) or just poor naming of the files (not really a problem).

Firstly, you should mark your comment within the source code to not confuse other readers.
You can do so, by putting a "//" in front and making it <i>italic</i> or <b>bold</b>, using the HTML tag for italic/bold font.

And secondly, what does the code for <i>Berry_Sambucus</i> have to do with the poisonChance of <i>Berry_Canina</i>?

If you mean, Berry_Canina has no user action concerning eating, then you should make that clear. Otherwise, your post reads as if you wanted to prove <b>A</b> with the evidence for <b>B</b>.

Regards,
Johnny

So if it's just about the skin file, what's all the code for then? This is confusing to me, which is why I posted this first comment.

Btw, since barries haven't been in the game from the beginning, do they actually update the server_data.pbo (again)?

And independant from that, can you provide me the copies of that pbo you've got, please? :-) I wasn't that clever to preserve me one for each version...

You can write me a forum message with a Rapidshare/Dropbox/WhatSoEver link in it.

Regards,
Johnny

R834 added a comment.Feb 16 2014, 2:55 PM

That code is out of gear_food.pbo and I assume is there to prove that the Sambucus is poisonous

_poisonChance = random 1; switch true do {case (_poisonChance < 0.05): {[0,_person,'FoodPoisoning_MediumImpact'] call event_modifier

I'm not sure how they've added the berries. When they very first came in (and didn't work), they were added to plants2_bush.pbo as a scroll menu option for the Sambucus and Canina plants, however that code has since gone.

The server_data.pbo will have been updated, but they haven't updated it for clients since since 0.32.

In 36.115.535 not solved
Only rename berries and add some description
class BerryBase : FruitBase {

		scope = public;
		displayName = $STR_ITEMS_BERRIES;
		descriptionShort = $STR_ITEMS_BERRIES;
		model = "\dz\gear\food\blueberries.p3d";
		absorbency = 0.4;
		
		class Nutrition {
			totalVolume = 40;
			energy = 70;
			water = 4;
			nutritionalIndex = 32;
		};
		
		class UserActions : UserActions {
			class Eat : Eat {
				displayNameDefault = $STR_USERACTIONS_EAT_BERRIES;
				useQuantity = 1;
				keepEmpty = 0;
			};
			
			class ForceFeed : ForceFeed {
				displayNameDefault = $STR_USERACTIONS_FEED_BERRIES;
				useQuantity = 1;
				keepEmpty = 0;
			};
		};
		handAnim[] = {"OFP2_ManSkeleton", "\DZ\anims\data\anim\sdr\ik\food\kiwi.rtm"};

};

class Berry_Sambucus : BerryBase {

		displayName = "Blue-coloured berries";
		descriptionShort = "Some kind of berries. Small and blue, but it's impossible to tell whether they are edible or not. Do you still remember your boyscout days?";
		
		class UserActions : UserActions {
			class Eat : Eat {
				onComplete = "_poisonChance = random 1; switch true do {case (_poisonChance < 0.05): {[0,_person,'FoodPoisoning_MediumImpact'] call event_modifier;}; case (_poisonChance < 0.85): {[0,_person,'FoodPoisoning_LightImpact'] call event_modifier;};};";
			};
			
			class ForceFeed : ForceFeed {
				onComplete = "_poisonChance = random 1; switch true do {case (_poisonChance < 0.05): {[0,_target,'FoodPoisoning_MediumImpact'] call event_modifier;}; case (_poisonChance < 0.85): {[0,_target,'FoodPoisoning_LightImpact'] call event_modifier;};};";
			};
		};

};

class Berry_Canina : BerryBase {

		displayName = "Red-coloured berries";
		descriptionShort = "Some kind of berries. Small and red, but it's impossible to tell whether they are edible or not. Do you still remember your boyscout days?";
		model = "\dz\gear\food\Poisonousberries.p3d";

};

This was a mix up with the artists, the models are correct. The naming of the models is just incorrect.