Page MenuHomePhabricator

JsonFileLoader Function errors & misbehavior
Closed, DuplicatePublic

Description

Engine Functionality with data manipulation ( JsonSerializer, FileWrite/FileRead/MakeDirectory )

Details

Severity
Major
Resolution
Open
Reproducibility
Always
Operating System
Windows 10 x64
Operating System Version
Latest Version
Category
Engine
Steps To Reproduce

Issue 1: JsonSerializer
The JsonSerializer with the recent 1.0 PC patch had few changes done to the way it functions, those changes included the size limit (write) and permissions of location to save ($CurDir,$profile,$saves). There seems to be errors with reading saved Json files that are written in such style:
(Multi-line)

{
    "Costal-0": {
        "8212.17 0 2781.53": 900
    },
    "Costal-1": {
        "6052.60 0 1868.23": 900
    },
    "Costal-2": {
        "8294.81 0 2915.43": 900
    }
}

To overcome this issue, setting the Boolean PrintNice to false will resolve it

m_Serializer.WriteToString( m_Data, PrintNice, StrJsonData );

This means there are issues with reading Json saves with multi-line data.

Issue 2: Function `MakeDirectory()`
It just does not work, anywhere ( server )

Additional Information
FPrint()
FPrintln()

Could sometimes not work as intended, attempted multiple times however difficult to reproduce. ( maybe something to do on my side )

All in all, the data manipulation system needs a good look at, since the recent change lots of bugs appeared.
Also the `Maximum file wirte size``` is WAY to small...less than 64kb? can barely write 16kb. Please fix. Maybe add the ability to manipulate the max size via startup parameter? same goes with FileWrite/Read and Directory attributes/permissions ( -scrFileRead = true -scrFileWrite = true -scrFileWriteMaxSize = 1024kb )